FYST-1728 Fix MD client address updates #5476
Conversation
|
Heroku app: https://gyr-review-app-5476-53297eee3a44.herokuapp.com/ |
There was a problem hiding this comment.
(Remember: this change should not impact mailing address from DF, which can be out-of state)
Found this in the note, seeing the tests be deleted, it looks like this change will make DF mailing address that is out of state hard-coded to "MD". What I think should happen is that if not :permanent_address_outside_md, we could hardcode? Happy to tuple!
Mailing address is that in the return header. We are hardcoding the Maryland permanent address in md502 which must always be in MD. This is the address we correct in the flow if it is out of state and the state is hardcoded to MD in the flow. |
| @@ -54,7 +54,7 @@ def document | |||
| xml.AddressLine1Txt sanitize_for_xml(@intake.permanent_street, 30) | |||
| xml.AddressLine2Txt sanitize_for_xml(@intake.permanent_apartment, 30) if @intake.permanent_apartment.present? | |||
| xml.CityNm sanitize_for_xml(@intake.permanent_city, 20) | |||
| xml.StateAbbreviationCd @intake.direct_file_data.mailing_state.upcase | |||
| xml.StateAbbreviationCd "MD" | |||
There was a problem hiding this comment.
confirmed that although the DF can send us the out of state mailing_state -- if the user confirms :permanent_address_outside_md it will lead the user to an ineligible screen. Which means that by the time we fill out the MD502, the user should've provided an address within MD (state hard coded on permanent address controller).
tahsinaislam
deleted the
FYST-1728-md-client-address-updates-should-update-xml
branch
Link to pivotal/JIRA issue
https://codeforamerica.atlassian.net/browse/FYST-1728
Is PM acceptance required? (delete one)
What was done?
How to test?
Screenshots (for visual changes)